Handle spaces in PHP binary path for the wp cli update command
#5855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the `wp cli update` command needs a Phar to work, trying to mimic what the `wp-cli-bundle` repo does in their Behat steps: - https://github.com/wp-cli/wp-cli-bundle/blob/2638a2601dcbedf7b6a905a57e8761946032505a/features/cli.feature#L31C7-L31C7 While running this locally (m1 Mac), I'm getting an error that looks like maybe the various repos aren't wired up correctly so I wonder if I'll get something different when running in GH workflow.
2 tasks
| @@ -357,7 +357,7 @@ public function update( $_, $assoc_args ) { | |||
|
|
|||
| $allow_root = WP_CLI::get_runner()->config['allow-root'] ? '--allow-root' : ''; | |||
| $php_binary = Utils\get_php_binary(); | |||
| $process = Process::create( "{$php_binary} $temp --info {$allow_root}" ); | |||
| $process = Process::create( Utils\esc_cmd( '%s %s --info %s', $php_binary, $temp, $allow_root ) ); | |||
There was a problem hiding this comment.
I think I'm rethinking my original suggestion to use Utils\esc_cmd(), as the originally proposed escapeshellarg( Utils\get_php_binary() ); covers less surface area.
Thoughts?
| Then STDOUT should be: | ||
| """ | ||
| Success: WP-CLI is at the latest version. | ||
| """ |
There was a problem hiding this comment.
Can you think of a way to add a scenario covering how the current code breaks?
bgturner
changed the title
wp cli update commandwp cli update command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
wp cli updatecommand to correctly handle spaces within the path to the PHP binary.Context
Within #5815 , one of the potential fixes was merged (#5818 ) and later reverted (Issue Comment Reverted commit: #5822 )
In the original issue, it was recommended to start testing this part of the code so here's a start!
Notes
I did run into some issues running this test locally, but it's passing here. Part of me wonders if the
make-phar.phpfile is too specifically tied to building the phar within the context of a GH workflow?