Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MediaRequestAuthenticator Core Data threading issue #23189

Merged

Conversation

kean
Copy link
Contributor

@kean kean commented May 10, 2024

Fixes an issue discovered when testing private Atomic sites.

There is a threading violation in this line that's being called from the background.

try? WPAccount.lookupDefaultWordPressComAccount(in: ContextManager.shared.mainContext)

I moved it to the main thread as a quick fix, but it really needs to be redesigned together with how session dependencies are managed in the app.

To test:

  • Open a private Atomic site
  • Open Media
  • Verify that Xcode doesn't report any Core Data threading violations

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean requested a review from momo-ozawa May 10, 2024 14:50
@kean kean marked this pull request as ready for review May 10, 2024 14:50
@kean kean added this to the Pending milestone May 10, 2024
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23189-78189d1
Version24.8
Bundle IDcom.jetpack.alpha
Commit78189d1
App Center Buildjetpack-installable-builds #8920
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23189-78189d1
Version24.8
Bundle IDorg.wordpress.alpha
Commit78189d1
App Center BuildWPiOS - One-Offs #9872
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit c055c21 into trunk May 13, 2024
26 of 27 checks passed
@kean kean deleted the fix/core-data-threading-violation--in-media-request-authenticator branch May 13, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants