Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications Refresh] Revert Packages.resolved changes #23188

Conversation

salimbraksa
Copy link
Contributor

@salimbraksa salimbraksa commented May 10, 2024

Description

This PR reverts Package.resolved changes introduced in #23147

Test Instructions

Verify the content of Package.resolved in trunk matches the one in this branch.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@salimbraksa salimbraksa changed the base branch from trunk to feature/notifications_refresh_p2 May 10, 2024 14:16
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 10, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23188-53f358f
Version24.8
Bundle IDcom.jetpack.alpha
Commit53f358f
App Center Buildjetpack-installable-builds #8948
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 10, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23188-53f358f
Version24.8
Bundle IDorg.wordpress.alpha
Commit53f358f
App Center BuildWPiOS - One-Offs #9899
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@salimbraksa salimbraksa force-pushed the task/notifications_revert_packages_changes branch from 7fc73a0 to 53f358f Compare May 10, 2024 14:36
@salimbraksa salimbraksa self-assigned this May 10, 2024
@salimbraksa salimbraksa marked this pull request as ready for review May 10, 2024 14:40
Copy link
Contributor

@alpavanoglu alpavanoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@salimbraksa salimbraksa merged commit eba626b into feature/notifications_refresh_p2 May 21, 2024
26 of 27 checks passed
@salimbraksa salimbraksa deleted the task/notifications_revert_packages_changes branch May 21, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants