New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use S3 for fastlane match #23186
Use S3 for fastlane match #23186
Conversation
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
google_cloud_bucket_name: 'a8c-fastlane-match', | ||
google_cloud_keys_file: File.join(SECRETS_DIR, 'google_cloud_keys.json'), | ||
storage_mode: 's3', | ||
s3_bucket: 'a8c-fastlane-match', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to add s3_region
to address a runtime warning. See Automattic/simplenote-macos#1150 (comment)
s3_bucket: 'a8c-fastlane-match', | |
s3_bucket: 'a8c-fastlane-match', | |
s3_region: 'us-east-2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the WooCommerce iOS review, woocommerce/woocommerce-ios#12692, what do you think of taking the chance to use app_store_connect_api_key
like in Pocket Casts Desktop
Of course, those are "refactors" as they don't change the behavior. Approving to unblock.
What says in the title. You can run
bundle exec fastlane ios update_certs_and_profiles
locally to verify this change.