Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use S3 for fastlane match #23186

Merged
merged 3 commits into from May 13, 2024
Merged

Conversation

crazytonyli
Copy link
Contributor

What says in the title. You can run bundle exec fastlane ios update_certs_and_profiles locally to verify this change.

@crazytonyli crazytonyli added the Tooling Build, Release, and Validation Tools label May 10, 2024
@crazytonyli crazytonyli added this to the 24.9 milestone May 10, 2024
@crazytonyli crazytonyli requested a review from a team May 10, 2024 02:37
@crazytonyli crazytonyli self-assigned this May 10, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.9. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23186-a701f3e
Version24.8
Bundle IDorg.wordpress.alpha
Commita701f3e
App Center BuildWPiOS - One-Offs #9866
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23186-a701f3e
Version24.8
Bundle IDcom.jetpack.alpha
Commita701f3e
App Center Buildjetpack-installable-builds #8914
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

google_cloud_bucket_name: 'a8c-fastlane-match',
google_cloud_keys_file: File.join(SECRETS_DIR, 'google_cloud_keys.json'),
storage_mode: 's3',
s3_bucket: 'a8c-fastlane-match',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to add s3_region to address a runtime warning. See Automattic/simplenote-macos#1150 (comment)

Suggested change
s3_bucket: 'a8c-fastlane-match',
s3_bucket: 'a8c-fastlane-match',
s3_region: 'us-east-2',

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the WooCommerce iOS review, woocommerce/woocommerce-ios#12692, what do you think of taking the chance to use app_store_connect_api_key like in Pocket Casts Desktop

Of course, those are "refactors" as they don't change the behavior. Approving to unblock.

@crazytonyli crazytonyli merged commit 01a1899 into trunk May 13, 2024
24 of 27 checks passed
@crazytonyli crazytonyli deleted the tonyli-migrate-fastlane-match-to-use-s3 branch May 13, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants