New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Update ReaderTagCell
to new UI
#23185
Conversation
Generated by 馃毇 Danger |
馃摬 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
馃摬 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty great right away. Much better than the other layout I had tried on Android.
2 small things that stand out:
- think we need more horizontal padding between the cards
- the skeleton loading state looks good. But then there's a much less subtle green loader for the images which load more slowly, which kinda draws too much attention. Could they keep just the grey skeleton effect?
- I think we had gone for tapping on a tag chip filtering the feed rather than drilling down. Not for the arrow at the end of the carousel, I think that works as expected.
I left some discussion items in slack where we can follow up further.
c75c384
to
93f2856
Compare
Hey @wargcm , I'm bumping the milestone for this PR to |
Fixed in abac353.
I was having some issues getting our ghost animation library to play nice with our custom image view. I'll try to fix this in a future PR.
Fixed in 93f2856. I've also updated the iPad sizing to match the Figma sizes in 5af9626. Thanks for taking a look! I'm going to mark this as ready for review. |
thanks @wargcm for the tweaks, as you marked ready for review does that mean I should see those updates if I install the build from this PR? |
@osullivanchris Yep! It looks like #23185 (comment) was updated to the latest commit automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good!
Looking good, thanks for the improvements. One small thing. When I get to the end of the carousels the view background is the standard grey rather than white, looks a bit off. |
Hey this is looking pretty tight overall. still seeing 4 lines of heading and excerpt in some cases, making the content taller than the image. I had suggested max 3 lines + 64 image. Or if we want to have 4 lines, bumping up the img to 80 so that the content lines up. But its not looking too bad or anything. One other tiny detail is maybe add 8pt padding under the tag heading, its getting a bit tight to the blog name. |
Latest changes are looking good for me. LGTM! |
6c2efd1
to
4e99197
Compare
Fixes #23184
Description
Updates the Reader tag cell to the new UI: p1715247952499939/1715197207.367749-slack-C05N140C8H5
Testing
To test:
Regression Notes
Potential unintended areas of impact
Should be none.
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: