[Notifications P2] Commen Moderation: Pending #23134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpavanoglu
changed the base branch from
feature/notifications-p2_comment-moderation-sheet
to
feature/notifications-p2_comment_moderation_view
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23134-e0cec11 | |
| Version | 24.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | e0cec11 | |
| App Center Build | WPiOS - One-Offs #9873 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23134-e0cec11 | |
| Version | 24.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | e0cec11 | |
| App Center Build | jetpack-installable-builds #8921 |
…ss-mobile/WordPress-iOS into feature/notifications-p2_comment-approval # Conflicts: # Modules/Sources/DesignSystem/Foundation/IconName.swift
…ss-mobile/WordPress-iOS into feature/notifications-p2_comment-approval
Base automatically changed from
feature/notifications-p2_comment_moderation_view
to
feature/notifications_refresh_p2
May 9, 2024 16:19
…ss-mobile/WordPress-iOS into feature/notifications-p2_comment-approval # Conflicts: # Modules/Sources/DesignSystem/Foundation/IconName.swift # WordPress/Classes/ViewRelated/Notifications/Comment Moderation/CommentModerationView.swift # WordPress/Classes/ViewRelated/Notifications/Comment Moderation/CommentModerationViewModel.swift
alpavanoglu
commented
May 9, 2024
Comment on lines
+41
to
+53
| // isNotificationComment ? WPAppAnalytics.track(.notificationsCommentApproved, | ||
| // withProperties: Constants.notificationDetailSource, | ||
| // withBlogID: notification?.metaSiteID) : | ||
| // CommentAnalytics.trackCommentApproved(comment: comment) | ||
| // | ||
| commentService.approve(comment, success: { [weak self] in | ||
| self?.state = .approved(liked: false) | ||
| // self?.showActionableNotice(title: ModerationMessages.approveSuccess) | ||
| // self?.refreshData() | ||
| }, failure: { /* [weak self] */ error in | ||
| // self?.displayNotice(title: ModerationMessages.approveFail) | ||
| // self?.commentStatus = CommentStatusType.typeForStatus(self?.comment.status) | ||
| }) |
There was a problem hiding this comment.
I left these as a reminder to not miss the existing functionality. Will be removed once the actions are implemented.
salimbraksa
reviewed
May 10, 2024
| ) | ||
| let hostingController = UIHostingController(rootView: commentModerationView) | ||
| containerStackView.addArrangedSubview(hostingController.view) | ||
| } |
There was a problem hiding this comment.
Hey @alpavanoglu, the moderation doesn't show up in my case even though comment.allowsModeration is true and comment status is pending.
After investigating the issue, I discovered that CommentModerationState(comment: comment) was returning nil because the comment.status for a pending comment is set to hold, not pending.
Suggestion: I think It would be more reliable to use the CommentDetailViewController.commentStatus property, which is of type CommentStatusType. This property was used in the outdated moderation view.
There was a problem hiding this comment.
That type seem to have draft as an option. I don't think it is relevant in Notifications context. We would need to handle the draft case. I've updated the value to hold now. Lmk if you have other concerns regarding that.
salimbraksa
reviewed
May 10, 2024
WordPress/Classes/ViewRelated/Notifications/Comment Moderation/CommentModerationView.swift
Show resolved
Hide resolved
alpavanoglu
merged commit 9a98fa3
into
feature/notifications_refresh_p2
24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #https://github.com/Automattic/wordpress-mobile/issues/33
Description
This PR adds the new Moderation View UI to the Comment Detail Screen. The functionality will follow with other PRs.
Acceptance Criteria
If the comment has the "Pending" moderation status, a moderation panel is displayed at the bottom of the comment details screen. There is a separator between the content and the panel.
1⃣ There is a label indicating the moderation state with a dedicated icon.
2⃣ Approve comment CTA button with an icon is visible but not actionable.
3⃣ More options CTA button opens a bottom sheet dialog containing all the available moderation options.
4⃣ The bottom sheet dialog presents "Approved," "Pending," "Thrash," and "Spam" options that are not actionable.
Testing Steps
Test in dark and light mode and with different dynamic font sizes.
Screenshot Reference
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: