Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of Cover block processor #22898

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 25, 2024

This PR follows the same approach taken in #22896 to improve the performance of Gutenberg processors. The overall improvement will be less significant in this case (that's why the PR is marked as Enhancement instead of Bug) mainly because the File block is used by fewer users than Image/Gallery blocks. Nevertheless, it will speed up the post-saving process.

To test:

Follow the testing instructions to cover the functionality related to the processors for the block:

Regression Notes

  1. Potential unintended areas of impact
    The block processors are only used when saving a post. No other area should be impacted.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested saving a post with Cover blocks.

  3. What automated tests I added (or what prevented me from doing so)
    Unit tests of the Cover block have been updated.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@fluiddot fluiddot added [Type] Enhancement Gutenberg Editing and display of Gutenberg blocks. labels Mar 25, 2024
@fluiddot fluiddot added this to the 24.6 milestone Mar 25, 2024
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22898-67e3041
Version24.5
Bundle IDorg.wordpress.alpha
Commit67e3041
App Center BuildWPiOS - One-Offs #9256
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22898-67e3041
Version24.5
Bundle IDcom.jetpack.alpha
Commit67e3041
App Center Buildjetpack-installable-builds #8300
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@fluiddot
Copy link
Contributor Author

While testing this PR, I spotted the issue #22901. I'll take the opportunity to address it here.

@irfano
Copy link
Member

irfano commented Apr 1, 2024

I'm moving this to the next milestone since this is not a blocker, and the code freeze will be completed today.

@irfano irfano modified the milestones: 24.6, 24.7 Apr 1, 2024
@momo-ozawa momo-ozawa modified the milestones: 24.7, 24.8 Apr 15, 2024
@momo-ozawa
Copy link
Contributor

momo-ozawa commented Apr 15, 2024

👋 Hey @fluiddot, I'm bumping this PR to 24.8 since it's code freeze day. If this PR needs to target 24.7, please target the release branch once it's been cut. Thanks!

@fluiddot fluiddot removed this from the 24.8 milestone Apr 15, 2024
Base automatically changed from update/improve-file-block-processor to update/improve-image-blocks-processor May 20, 2024 18:45
Base automatically changed from update/improve-image-blocks-processor to trunk May 21, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants