Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant if check in testGetAuthCookie #22828

Draft
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Draft

Remove redundant if check in testGetAuthCookie #22828

wants to merge 6 commits into from

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Mar 14, 2024

There was already an XCTAssertEqual for that value.Fixes #

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@mokagio
Remove redundant if check in testGetAuthCookie
9d7507c 
There was already an `XCTAssertEqual` for that value.
@mokagio
Replace multi-if with XCTAssertEquals in testGetAuthCookie
d32cdeb 
This will help us better identify test failures. Rather that the whole
if not running its successful branch, we'll get failures for each
`cookie` property that did not match expectation.
@mokagio
HACK CI for faster feedback
a8942d5
@mokagio
HACK - Repeat test on failure 10 times
9b69380
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 14, 2024 •
edited

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@mokagio
Rewrite testGetAuthCookie async expectation using Nimble
fabd539 
This is to see whether Nimble's approach to waiting for async code
results in less timeouts than XCTest.
@mokagio
HACK - Run 20x the amount of unit tests
d854d96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mokagio @dangermattic