Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide fallback URLs to load P2s in web view #22554

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Feb 6, 2024

This PR aims to provide a workaround for loading P2 content when your user doesn't have membership.

Before: An error was shown that the post couldn't be loaded. There was no way to grant membership.
After: An error is shown with the option to load the post in the browser. Once the post is loaded the user can grant themselves membership.

Note: This would need to be heavily tested for regressions unless we can add checks to filter only for A8C users.

Option to open in browser P2 opened in browser
Simulator Screenshot - iPhone 15 - 2024-02-06 at 14 44 00 Simulator Screenshot - iPhone 15 - 2024-02-06 at 14 44 09

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Feb 6, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@twstokes twstokes added the P2 Support P2 features in the apps label Feb 6, 2024
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22554-28c7a10
Version24.2
Bundle IDcom.jetpack.alpha
Commit28c7a10
App Center Buildjetpack-installable-builds #7725
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22554-28c7a10
Version24.2
Bundle IDorg.wordpress.alpha
Commit28c7a10
App Center BuildWPiOS - One-Offs #8698
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Support P2 features in the apps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants