Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change var to const #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change var to const #18

wants to merge 1 commit into from

Conversation

1shaked
Copy link

@1shaked 1shaked commented May 31, 2021

The best practice of using const where var is not going to change in the next pull request I will also add optional changing to avoid can not read property of undefined

The best practice of using const where var is not going to change in the next pull request I will also add optional changing to avoid can not read property of undefined
@1shaked
Copy link
Author

1shaked commented Sep 5, 2021

is this repo still active??

@tagomoris
Copy link
Member

This is still active. I didn't see the detail of this change because the CI was failing.

@1shaked
Copy link
Author

1shaked commented Sep 6, 2021

The ci was failing automatically, you can the the file changes and what I changed just by clicking on the commit

@1shaked
Copy link
Author

1shaked commented Sep 6, 2021

like var msiePattern = /MSIE ([.0-9]+);/;
var tridentPattern = /Trident/[.0-9]+;/;
var tridentVersionPattern = / rv:([.0-9]+)/;
var iemobilePattern = /IEMobile/([.0-9]+);/;
to this
const msiePattern = /MSIE ([.0-9]+);/;
const tridentPattern = /Trident/[.0-9]+;/;
const tridentVersionPattern = / rv:([.0-9]+)/;
const iemobilePattern = /IEMobile/([.0-9]+);/;

@tagomoris
Copy link
Member

@1shaked Could you rebase this branch on the current master (after #21 )?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants