-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PipelineListsOptions to woodpecker-go #3652
base: main
Are you sure you want to change the base?
Conversation
How do we handle such PRs in general? Keep it open until we want to do a major version bump? |
We actually just merged them and ignored that they're breaking... |
Maybe we should just move the lib to a dedicated repo? But same argumentation might apply to cli, agent etc. which would end in a repo mess instead of the current monorepo approach. So maybe a bad idea 🙃 |
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3652.surge.sh |
I fear that's a breaking change... It's a bit pain IMO that we can not version the go lib independent of the server.
I don't see a (good) way to make it non-breaking. If you have a better idea, please let me know. However, as this will be breaking anyway, we should replace all other raw query parameters used in the lib (e.g. https://github.com/woodpecker-ci/woodpecker/blob/main/woodpecker-go/woodpecker/repo.go#L6) by proper opt structs as well as this makes it easier to extend with future options.
Changes:
PipelineListOptions
and expose them to cliRepoListOptions
and expose them to cliDeployOptions
PipelineStartOptions
PipelineLastOptions
RepoPostOptions
RepoMoveOptions