Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint to v9 - abandoned #3594

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 6, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) ^8.56.0 -> ^9.0.0 age adoption passing confidence

Release Notes

eslint/eslint (eslint)

v9.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - "before 4am" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies ui frontend related labels Apr 6, 2024
@renovate renovate bot force-pushed the renovate/eslint-9.x branch 5 times, most recently from 800b5ab to 4baf65e Compare April 8, 2024 06:10
@renovate renovate bot changed the title Update dependency eslint to v9 chore(deps): update dependency eslint to v9 Apr 9, 2024
@renovate renovate bot force-pushed the renovate/eslint-9.x branch 4 times, most recently from ad42132 to 3be8dd1 Compare April 10, 2024 10:35
@qwerty287
Copy link
Contributor

qwerty287 commented Apr 10, 2024

This update is not possible yet because most plugins don't support eslint 9 yet. I started migration work for the other ones

Waiting for:

@qwerty287 qwerty287 marked this pull request as draft April 10, 2024 12:39
@qwerty287 qwerty287 self-assigned this Apr 10, 2024
Copy link
Contributor Author

renovate bot commented Apr 10, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@renovate renovate bot changed the title chore(deps): update dependency eslint to v9 chore(deps): update dependency eslint to v9 - abandoned May 9, 2024
Copy link
Contributor Author

renovate bot commented May 9, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@qwerty287 qwerty287 changed the title chore(deps): update dependency eslint to v9 - abandoned chore(deps): update dependency eslint to v9 May 9, 2024
@renovate renovate bot changed the title chore(deps): update dependency eslint to v9 chore(deps): update dependency eslint to v9 - abandoned May 9, 2024
@anbraten
Copy link
Member

@qwerty287 I did some further testing to update to v9. https://github.com/antfu/eslint-config seems to be a quite common preset including a nice set of rules. I've also added @intlify/eslint-plugin-vue-i18n to detect missing translations. What do you think?

@qwerty287
Copy link
Contributor

In general looks fine, but I didn't look into details.
If we still have most of the linters we had before I'm totally fine it.

@qwerty287
Copy link
Contributor

qwerty287 commented May 30, 2024

@anbraten Can you take a look at my recent commits?

I'm fine with using antfu so far.

What I changed:

  • enabled some additional plugins and configs we used before (if they're not included in antfu)
  • cleaned up dependencies
  • fixed most issues - those are not solved yet: I don't know/am unsure about how to fix. Can you check them?

Two questions:

  1. Why did you remove the prettier plugin?
  2. Does antfu check import sorting?

Only the promise plugin is missing eslint 9 support now, so I think we could merge this and enable the plugin later.

@anbraten
Copy link
Member

  • Why did you remove the prettier plugin?

Eslint by default does not have any stylistic rules anymore. Therefore it normally does not interfere with prettier.

  • Does antfu check import sorting?

I wanted to start using @ianvs/prettier-plugin-sort-imports instead as its much faster with autosorting in ides.

@qwerty287
Copy link
Contributor

I wanted to start using @ianvs/prettier-plugin-sort-imports instead as its much faster with autosorting in ides

Do you want to add it here or in a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants