-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use actual title of event subjects if possible #3421
base: main
Are you sure you want to change the base?
Conversation
Actually the |
This also change webui |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3421 +/- ##
==========================================
+ Coverage 36.07% 36.15% +0.07%
==========================================
Files 228 228
Lines 15495 15519 +24
==========================================
+ Hits 5590 5611 +21
+ Misses 9498 9497 -1
- Partials 407 411 +4 ☔ View full report in Codecov by Sentry. |
Could you add some screenshots before & after |
there should not be much difference to spot ... but I can do so |
I just noticed one strange UI bug: @anbraten do you have any idea? |
I am actually not sure if we should use the html title attribute for this. It was used to show the complete commit message before. |
feel free to push to my branch :) |
At the moment we did mostly ignore the title of things and used the first line of the object descriptions.
Now we try to retrieve the actual title if an object can have one.