Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual title of event subjects if possible #3421

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 22, 2024

At the moment we did mostly ignore the title of things and used the first line of the object descriptions.

Now we try to retrieve the actual title if an object can have one.

@6543 6543 added enhancement improve existing features blocked It's ready but something external is blocking it forge/github github forge related forge/gitlab gitlab forge related forge/gitea gitea forge related forge/bitbucket bitbucket forge related labels Feb 22, 2024
@qwerty287
Copy link
Contributor

Actually the title field of pipelines is unused if I remember correctly 🤔 or is it shown in ui?

@6543
Copy link
Member Author

6543 commented Feb 22, 2024

This also change webui

@6543 6543 marked this pull request as ready for review February 22, 2024 09:21
@6543 6543 removed forge/github github forge related forge/gitlab gitlab forge related forge/gitea gitea forge related forge/bitbucket bitbucket forge related blocked It's ready but something external is blocking it labels Feb 22, 2024
@6543 6543 added the server label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 55.12821% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 36.15%. Comparing base (9013156) to head (59086fe).

Files Patch % Lines
server/forge/gitea/gitea.go 22.22% 24 Missing and 4 partials ⚠️
server/forge/bitbucketdatacenter/convert.go 50.00% 3 Missing and 2 partials ⚠️
server/forge/github/parse.go 91.66% 1 Missing ⚠️
server/forge/gitlab/convert.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3421      +/-   ##
==========================================
+ Coverage   36.07%   36.15%   +0.07%     
==========================================
  Files         228      228              
  Lines       15495    15519      +24     
==========================================
+ Hits         5590     5611      +21     
+ Misses       9498     9497       -1     
- Partials      407      411       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anbraten
Copy link
Member

This also change webui

Could you add some screenshots before & after

@6543 6543 requested a review from qwerty287 February 22, 2024 10:22
@6543 6543 added this to the 2.4.0 milestone Feb 22, 2024
@6543
Copy link
Member Author

6543 commented Feb 22, 2024

there should not be much difference to spot ... but I can do so

@6543
Copy link
Member Author

6543 commented Feb 22, 2024

image
image
(before mouse hove over just showed "New Pull" too)

@6543
Copy link
Member Author

6543 commented Feb 22, 2024

I just noticed one strange UI bug:
vid-20240222-173553.webm

@anbraten do you have any idea?

@anbraten
Copy link
Member

I am actually not sure if we should use the html title attribute for this. It was used to show the complete commit message before.

@6543
Copy link
Member Author

6543 commented Feb 22, 2024

feel free to push to my branch :)

@qwerty287 qwerty287 modified the milestones: 2.4.0, 2.5.0 Feb 26, 2024
@anbraten anbraten modified the milestones: 2.5.0, 2.6.0 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants