Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Block Editor: tweak styles/layout of attribute modal implementation #47374

Merged
merged 5 commits into from May 13, 2024

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented May 10, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This polishes the Attributes modal implementation:

  1. Align the help component of the Attribute terms
  2. Reduce Spinner size to fit correctly in the Attributes help area
  3. Set the height for each row to avoid flicks effects
  4. Remove focus styles in the terms component user selects it

Closes # .

  1. Enable the Product Editor

  2. Go to the Variations section

  3. Start to add a new attribute

  4. Confirm "Align the help component of the Attribute terms":

Screenshot 2024-05-10 at 18 08 20
  1. Confirm "Reduce Spinner size to fit correctly in the Attributes help area"
Screenshot 2024-05-10 at 18 09 14
  1. Set the height for each row to avoid flicks effects

Confirm each row has a min-height of 80px:

image
  1. Remove focus styles in the terms component user selects it

Confirm it doesn't add an outline style when clicking on it:

image

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@retrofox retrofox self-assigned this May 10, 2024
@retrofox retrofox requested a review from a team May 10, 2024 17:03
@retrofox retrofox added focus: new product ux revamped product management experience team: Mothra labels May 10, 2024
Copy link
Contributor

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Looks good :)

@retrofox retrofox merged commit 7c1da81 into trunk May 13, 2024
27 of 28 checks passed
@retrofox retrofox deleted the update/product-editor-tweak-attributes-layout branch May 13, 2024 18:02
@github-actions github-actions bot added this to the 9.0.0 milestone May 13, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 13, 2024
@rodelgc rodelgc added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: new product ux revamped product management experience needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris team: Mothra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants