This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Details Block > Fix the review form rating #8431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com/woocommerce/woocommerce-blocks into feat/add-single-product-details-block
…ocks into feat/add-single-product-details-block
…block is used alongside the Classic Single Product Block.
woocommercebot
requested review from
a team and
Aljullu
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +74 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
gigitux
suggested changes
Feb 15, 2023
gigitux
reviewed
Feb 15, 2023
src/BlockTypes/ProductDetails.php
Outdated
| * @return array The updated comment form arguments. | ||
| */ | ||
| public function review_comment_form( $comment_form ) { | ||
| $comment_form['comment_field'] = '<div class="comment-form-rating"><label for="rating">' . esc_html__( 'Your rating', 'woo-gutenberg-products-block' ) . ( wc_review_ratings_required() ? ' <span class="required">*</span>' : '' ) . '</label><select name="rating" id="rating-select" required> |
There was a problem hiding this comment.
If we can fix the stars issue, I think that we should add this logic too.
Base automatically changed from
feat/add-single-product-details-block
to
trunk
February 16, 2023 10:18
Aljullu
reviewed
Feb 21, 2023
There was a problem hiding this comment.
Thanks for working on this, @nefeline! I can confirm it solves the issue.
I'm not 100% sure about this solution, though. To me, it might be better to update the script that adds the stars in WC core so it supports several instances of #rating. Sidenote: if we go that route, we should probably also change the selector to not use an id, ie: select[name='rating'].
I don't have a strong opinion, though. The template is using ids so having the Product Details block + the Classic Template in the same template will give unexpected issues, anyway.
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
danielwrobert
added
type: cooldown
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
github-actions
bot
removed
the
status: stale
|
I'm removing the issue and this PR from the scope of the Blockified Single Product Template. @nefeline feel free to continue to work on this if you want! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the new Single Product Details block, we noticed the star ratings are duplicated when this block is used alongside the classic Single Product block.
Fixes woocommerce/woocommerce#42475
Screenshots
Testing
User Facing Testing
WooCommerce Visibility
Changelog