Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove propTypes definitions from Reviews By Product #10249

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

hritikchaudhary
Copy link
Contributor

@hritikchaudhary hritikchaudhary commented Jul 18, 2023

Fixes woocommerce/woocommerce#42362

Changes in the PR:

Removed propTypes definitions from Reviews By Product.

Testing

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

User Facing Testing

  • Do not include in the Testing Notes

WooCommerce Visibility

  • WooCommerce Core
  • Feature plugin
  • Experimental

@hritikchaudhary
Copy link
Contributor Author

hritikchaudhary commented Jul 18, 2023

Please check individual commit as even with git mv github is displaying block.tsx as new addition. All the relevant changes are in this commit - 51b76a9 rest commits are for renaming.
I renamed edit.tsx to block.tsx to keep the consistency with other blocks and it also helped resolve a TS error in index.tsx

@github-actions
Copy link
Contributor

This PR has been marked as stale because it has not seen any activity within the past 7 days. Our team uses this tool to help surface pull requests that have slipped through review.

If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Jul 25, 2023
@github-actions github-actions bot removed the status: stale Stale issues and PRs have had no updates for 60 days. label Sep 24, 2023
Copy link
Contributor

@kmanijak kmanijak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hritikchaudhary!

Thanks a lot for your contribution!

By looking at the changes I don't think moving majority of the code from edit.tsx to block.tsx file is a good idea. There's a lot of code strictly related to Editor side (e.g. renderEditMode and whole Inspector Controls implementation).

I recommend to either stick only to removing propTypes definition or if you want to cleanup the code, split the block definition and Editor related code into block.tsx and edit.tsx. 🙏


Also, I’d like you to know that this weekend (8-9 December) WooCommerce Blocks repo will be migrated to WooCommerce monorepo.

However, open PRs won’t be migrated. That means open PRs have to be merged by the end of this week or otherwise, you’ll have to open/recreate a new PR in a monorepo post-migration if you’re interested in finalizing this contribution.

Thanks!

Copy link
Contributor

This PR has been marked as stale because it has not seen any activity within the past 7 days. Our team uses this tool to help surface pull requests that have slipped through review.

If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: stale Stale issues and PRs have had no updates for 60 days. team: Kirigami & Origami type: community contribution
Projects
None yet
4 participants