Speed up if tables are involved and changed highlighting of parameters in steps #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… method can take a long time. Therefore, the step-text is cut till the start of the table. This speeds up the matches(...) to an acceptable time.
…the annotator and not by an inspection.
|
I changed the parser to have its own token for "GivenStories:". Now, the file-path of a GivenStory is a token and has its own text-style. You can ctrl+click it now and you will jump to the specified file. There is also a completion for GivenStories. |
|
Thanks, I'll take a look later. On Tue, Feb 10, 2015, 12:59 Dinis de Brito e Cunha notifications@github.com
|
…ory step is contained in a java step. TokenMap doesn't resolve this, because it thinks, that the rest of the line is a parameter. This must be resolved in ParametrizedString.
… resolving parameters in story steps.
…to get rid of ParameterizedString.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a bug fix in JBehaveStepsIndex. If tables where passed to steps, the plugin was slowed down to a felt freeze of the IDE. My change cuts the steptext till the beginning of the table. E.g.
"Given A table:
| a | b|
| c | d |
"
is cut down to: "Given A table:". Then this cut down text is matched against the stepdefinitions.
We had this problem, because we have more than 800 stepdefinitions and many tables. The tables have more than 4 rows and 4 columns.
The second change is a move of the parameters highlighting from UndefinedStepInspection to the StoryAnnotator (including a bug fix).
The third change includes some resolving of deprecation issues and null-pointer checking.
All those changes were done for Intellij 14.0.2 and JDK 1.7.0_71