New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update shikiConfig.experimentalThemes
-> shikiConfig.themes
#8243
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @austincrim ! I have to admit, I'm super confused because we did in fact have a corresponding docs PR to accompany 4.5:
Somehow, the old wording must have been reintroduced in a later PR. But we appreciate you taking the time to fix this, and are happy to welcome you to Team Docs! 🥳
…astro#8243) Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
…astro#8243) Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
…astro#8243) Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Description (required)
It appears that Astro 4.5 stabilized dual theme support for Shiki and updated this property name.
experimentalThemes
did not work for me withastro@4.8.0
.