Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Zed #8238

Merged
merged 9 commits into from May 14, 2024
Merged

Add Zed #8238

merged 9 commits into from May 14, 2024

Conversation

jacobdalamb
Copy link
Contributor

@jacobdalamb jacobdalamb commented May 9, 2024 •
edited

From previous closed PR now that this issue is fixed thanks to @Princesseuh

Description (required)
Zed is a newly open sourced code editor that has recently added built-in support for Astro and is gaining traction as the repo is nearing 30k stars.

Related issues & labels (optional)
Closes #6863

@vercel Vercel
Copy link

vercel bot commented May 9, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 10:54am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) May 14, 2024 10:54am

@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 9, 2024 •
edited

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en editor-setup.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

at-the-vr
at-the-vr reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sarah11918
sarah11918 reviewed May 13, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for re-adding this again now that the feature is more stable. Just a quick suggestion for better maintenance going forward!

src/content/docs/en/editor-setup.mdx Outdated Show resolved Hide resolved
jacobdalamb and others added 2 commits May 13, 2024 11:01
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels May 13, 2024
@sarah11918
Copy link
Member

!coauthor

@github-actions GitHub Actions
Copy link 

Co-authored-by: Houston (Bot) <108291165+astrobot-houston@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Atharva <atharvapise19@gmail.com>

@sarah11918 sarah11918 merged commit 9437b02 into withastro:main May 14, 2024
8 checks passed
@jacobdalamb jacobdalamb deleted the chore/editor-setup branch May 14, 2024 15:21
@huyikai huyikai mentioned this pull request May 15, 2024
Merged
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@jacobdalamb @sarah11918
@at-the-vr @wpplumber
Add Zed (withastro#8238)
4220740 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Atharva <atharvapise19@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@jacobdalamb @sarah11918
@at-the-vr @wpplumber
Add Zed (withastro#8238)
3163495 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Atharva <atharvapise19@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@jacobdalamb @sarah11918
@at-the-vr @wpplumber
Add Zed (withastro#8238)
11f1d40 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Atharva <atharvapise19@gmail.com>
@jsparkdev jsparkdev mentioned this pull request May 17, 2024
Merged
@at-the-vr at-the-vr mentioned this pull request May 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@at-the-vr at-the-vr at-the-vr left review comments

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Zed (code editor)
4 participants
@jacobdalamb @astrobot-houston @sarah11918 @at-the-vr