Added a System.Logger Notifier implementation and deprecated the Slf4 notifier #2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…j notifier. Also removed Slf4j from the runtime dependencies.
ciscoo
reviewed
Feb 24, 2024
|
|
||
| @Override | ||
| public void info(String message) { | ||
| if (verbose) { |
There was a problem hiding this comment.
Why not:
if (logger.isLoggable(Level.INFO)) {
// ...
}Let the user configure the logging system however they want it.
There was a problem hiding this comment.
If there was a lot of processing to happen inside the if block it'd be worth it, but since we just log the parameter value we're given there's no performance gain to be had really.
Having said that if (verbose) is basically redundant since that parameter is only used in standalone mode which defaults to the console notifier, so I'll remove that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address #2557 and more general concerns about slf4j versions and shading.
By removing WireMock's direct dependency on slf4j this frees the user to make their own arrangements and use
org:slf4j:slf4j-jdk-platform-loggingwith their own library versions if needed.