Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce @WireMockTest annotation parameter that allows every SSL certificate #2503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kkocel
Copy link
Contributor

@kkocel kkocel commented Nov 24, 2023

References

  • TODO

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • Recommended: If you participate in Hacktoberfest 2023, make sure you're signed up there and in the WireMock form
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@kkocel kkocel requested a review from a team as a code owner November 24, 2023 14:01
@kkocel
Copy link
Contributor Author

kkocel commented Nov 24, 2023

@oleg-nenashev Hi, I created this PR because I wanted complete instrumentation for tests from within a single annotation. Let me know if this approach is ok. If so, I will create subsequent PR in the documentation.

@oleg-nenashev
Copy link
Member

I will review it later from the laptop, no objections after a quick check

@tomakehurst
Copy link
Member

I'm not 100% clear on the intent/use case for this.

Is it essentially that if your app under test uses HttpsUrlConnection when talking to mock APIs, that it'll accept WireMock's self-signed certificate when this option is enabled?

@kkocel
Copy link
Contributor Author

kkocel commented Nov 24, 2023

@tomakehurst I intended to implement this parameter to support all clients, but it may be impossible...

@tomakehurst tomakehurst self-assigned this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants