Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add yaml support for stub mapping configuration files #2436

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

karanjamutahi
Copy link

@karanjamutahi karanjamutahi commented Oct 11, 2023

References

#2411

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • Recommended: If you participate in Hacktoberfest 2023, make sure you're signed up there and in the WireMock form
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@oleg-nenashev
Copy link
Member

@karanjamutahi thanks! Could you please summarize how far it was reviewed during the hackfest? Maybe @Mahoney could take a look as a mntor there. Also, please register for hacktoberfest as mentioned in the PR template

@karanjamutahi karanjamutahi changed the title Add yaml support for stub mapping configuration files WIP: Add yaml support for stub mapping configuration files Oct 18, 2023
@karanjamutahi
Copy link
Author

A few questions came up mostly around the many features yaml to test for.
I need to box out some time to knock it off but there shouldn't be too much left to do.

@karanjamutahi karanjamutahi marked this pull request as draft October 18, 2023 21:17
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In longer run I would switch to a framework like picocli that makes it easier tmake interexchangeable configs and to embed CLI options there, but it is a good progress towards better flexibility of the code. Still needs to be taken over the line. @karanjamutahi lemme know if any help is needed

@oleg-nenashev
Copy link
Member

@karanjamutahi Hi! It would be great to get it over the line. Let me know if I could help somehow

@tomakehurst tomakehurst self-assigned this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants