-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WT-12083 Extend conn_api.c to support new get_configuration method #9932
WT-12083 Extend conn_api.c to support new get_configuration method #9932
Conversation
Hi @y123456yz, thank you for your submission! |
The background is as follows:
When we modify the configuration information of WT multiple times, Mongo server can only retain the last result and cannot obtain all modification records. |
after wt merge this PR's code, I will add a PR to mongo server, perfect "db.adminCommand( { getParameter : "1", wiredTigerEngineRuntimeConfig : 1 } )", By get_configure api to obtain complete wt configuration information. |
@clarissecheah |
src/conn/conn_api.c
Outdated
CONNECTION_API_CALL(conn, session, reconfigure, config, cfg); | ||
ret = __wt_conn_reconfig(session, cfg); | ||
err: | ||
API_END_RET(session, ret); | ||
} | ||
|
||
/* | ||
* __conn_get_home -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't pick this one up earlier - sorry! This should be:
__conn_get_configuration
instead of __conn_get_home
I believe this will fix the s_all
issue we have in the evergreen patch failure.
Hi @y123456yz, one more thing - there's currently a known issue being fixed in clang analyzer that's causing the Evergreen patch failure we see. Could you merge the develop branch into your branch when you fix the comment I mentioned above? I'll re-review after, but this PR looks good to go after that. Thanks! |
…to develop_config_get_surport
hi, @clarissecheah |
Hi @y123456yz , it appears as though
Could I just double check that you've run |
…to develop_config_get_surport
hi, @clarissecheah you can feel free to modify my code branches, If there are any other problems, Please help me with this. thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the mongo server PR: |
get connection configure string surport, connection api surport get_configure.