Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT-12083 Extend conn_api.c to support new get_configuration method #9932

Merged

Conversation

y123456yz
Copy link
Contributor

get connection configure string surport, connection api surport get_configure.

Copy link

Hi @y123456yz, thank you for your submission!
Please make sure to sign our Contributor Agreement (if you haven't already) and provide us with editor permissions on your branch. Instructions on how do that can be found here.

@y123456yz
Copy link
Contributor Author

The background is as follows:

db.adminCommand( { setParameter : 1, "wiredTigerEngineRuntimeConfig" : "io_capacity=(total=110M)"})
{ "was" : "", "ok" : 1 }

db.adminCommand( { setParameter : 1, "wiredTigerEngineRuntimeConfig" : "eviction=(threads_min=8, threads_max=12)"})
{ "was" : "io_capacity=(total=110M)", "ok" : 1 }

db.adminCommand( { setParameter : 1, "wiredTigerEngineRuntimeConfig" : "verbose=[api:5]"})
{ "was" : "eviction=(threads_min=8, threads_max=12)", "ok" : 1 }

db.adminCommand( { getParameter : "1", wiredTigerEngineRuntimeConfig : 1 } )
{ "wiredTigerEngineRuntimeConfig" : "verbose=[api:5]", "ok" : 1 }

image

When we modify the configuration information of WT multiple times, Mongo server can only retain the last result and cannot obtain all modification records.

@y123456yz
Copy link
Contributor Author

y123456yz commented Dec 5, 2023

after wt merge this PR's code, I will add a PR to mongo server, perfect "db.adminCommand( { getParameter : "1", wiredTigerEngineRuntimeConfig : 1 } )", By get_configure api to obtain complete wt configuration information.

@y123456yz y123456yz changed the title get connection configure string surport, connection api surport get_configure. connection api surport get_configure. fix mongo server's wiredTigerEngineRuntimeConfig info Incomplete. Dec 5, 2023
@y123456yz
Copy link
Contributor Author

WT-12083

@y123456yz y123456yz changed the title connection api surport get_configure. fix mongo server's wiredTigerEngineRuntimeConfig info Incomplete. WT-12083: connection api surport get_configure. fix mongo server's wiredTigerEngineRuntimeConfig info Incomplete. Dec 5, 2023
examples/c/ex_all.c Outdated Show resolved Hide resolved
examples/c/ex_all.c Outdated Show resolved Hide resolved
src/include/wiredtiger.in Outdated Show resolved Hide resolved
src/conn/conn_api.c Outdated Show resolved Hide resolved
src/conn/conn_api.c Outdated Show resolved Hide resolved
@y123456yz
Copy link
Contributor Author

@clarissecheah
I have change the code, please review again.
thanks.

examples/c/ex_all.c Outdated Show resolved Hide resolved
@clarissecheah clarissecheah changed the title WT-12083: connection api surport get_configure. fix mongo server's wiredTigerEngineRuntimeConfig info Incomplete. WT-12083 Extend conn_api.c to support new get_configuration method Dec 15, 2023
CONNECTION_API_CALL(conn, session, reconfigure, config, cfg);
ret = __wt_conn_reconfig(session, cfg);
err:
API_END_RET(session, ret);
}

/*
* __conn_get_home --
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't pick this one up earlier - sorry! This should be:

__conn_get_configuration instead of __conn_get_home

I believe this will fix the s_all issue we have in the evergreen patch failure.

@clarissecheah
Copy link
Contributor

clarissecheah commented Dec 18, 2023

Hi @y123456yz, one more thing - there's currently a known issue being fixed in clang analyzer that's causing the Evergreen patch failure we see. Could you merge the develop branch into your branch when you fix the comment I mentioned above? I'll re-review after, but this PR looks good to go after that. Thanks!

@y123456yz
Copy link
Contributor Author

Hi @y123456yz, one more thing - there's currently a known issue being fixed in clang analyzer that's causing the Evergreen patch failure we see. Could you merge the develop branch into your branch when you fix the comment I mentioned above? I'll re-review after, but this PR looks good to go after that. Thanks!

hi, @clarissecheah
I have change the comment and run the newest s_all.
thanks.

@clarissecheah
Copy link
Contributor

Hi @y123456yz , it appears as though s_all is still failing in the patch build. See below:

.947] + echo ####################### MESSAGE ############################
[2023/12/19 09:44:03.947] ####################### MESSAGE ############################
[2023/12/19 09:44:03.947] + echo s_all run of: "./s_clang_format " resulted in:
[2023/12/19 09:44:03.947] s_all run of: "./s_clang_format " resulted in:
[2023/12/19 09:44:03.948] + sed -e s/^/ / __wt.38565
[2023/12/19 09:44:03.948]  Modifying examples/c/ex_all.c

Could I just double check that you've run s_all and committed any changes (e.g. in s_clang_format)?

@y123456yz
Copy link
Contributor Author

s_clang_format

hi, @clarissecheah
I merge the develop and run s_all again, It should be okay this time.

you can feel free to modify my code branches, If there are any other problems, Please help me with this.

thanks.
:)

Copy link
Contributor

@clarissecheah clarissecheah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarissecheah clarissecheah merged commit c5a9a82 into wiredtiger:develop Dec 21, 2023
7 checks passed
@y123456yz
Copy link
Contributor Author

the mongo server PR:
mongodb/mongo#1587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants