Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/split view command/js #1640

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cybermerlin
Copy link
Contributor

added the ability to set the css class style icon in SplitViewCommand

@msftclas
Copy link

msftclas commented Jun 2, 2016

Hi @cybermerlin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@cybermerlin
Copy link
Contributor Author

cybermerlin commented Jul 25, 2016

src/js/WinJS/Controls/Flyout.js:
line 1372 col 56 (W116) Expected '!==' and instead saw '!='.
line 1393 col 100 (W116) Expected '!==' and instead saw '!='.
line 1402 col 100 (W116) Expected '!==' and instead saw '!='.
3 lint errors

I do not change this file. Merge please this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants