Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change casing of gamepad enum props from uppercase "G" to lowercase "g". #1514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change casing of gamepad enum props from uppercase "G" to lowercase "g". #1514

wants to merge 1 commit into from

Conversation

jdalton
Copy link
Contributor

@jdalton jdalton commented Oct 10, 2015

This PR addresses #1435.

@mikewjackson
Copy link

Is this a breaking change?

@jdalton
Copy link
Contributor Author

jdalton commented Oct 10, 2015

@mikewjackson
Yes-ish...maybe. I'll ping you in email.
This PR is more of a placeholder for when it would be appropriate and to get my feet wet.

@jdalton
Copy link
Contributor Author

jdalton commented Oct 10, 2015

@payzer
I'm kicking this around a bit and noticed that in MediaPlayer.js there are ev.key === "GamepadB" checks which map well to the capital "G" enums.

Also, I noticed the mapping for something like GamepadA is 195 which I assume is an ev.keyCode value when pressing the key in the Xbox browser. It looks like desktop browsers don't get those key codes and have to use the Gamepad API, right?

@payzer
Copy link
Contributor

payzer commented Oct 10, 2015

@jdalton Your assumption is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdalton @mikewjackson @payzer @msftclas @msftgits