Skip to content

Commit

Permalink
Fix #976 Build output doesn't have BOMs
Browse files Browse the repository at this point in the history
The problem was that the line-ending task ran after the add-bom task and
happened to remove the BOM. Swapping the order of these tasks causes the
build output to have both a BOM and the correct line endings.

It would be nice to have a build task that runs during "release" that
fails the build if the output is missing a BOM or has the wrong line
endings.
  • Loading branch information
Adam Comella authored and xirzec committed Mar 25, 2015
1 parent 73d19ed commit 420c21f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
// Private tasks (not designed to be used from the command line)
grunt.registerTask("_copyFinal", ["copy:tests", "copy:testDeps", "copy:fonts", "copy:intellisense"]);
grunt.registerTask("_copyToTsBuild", ["copy:srcjs"]);
grunt.registerTask("_postProcess", ["add-bom", "line-endings"]);
grunt.registerTask("_postProcess", ["line-endings", "add-bom"]);

// Other tasks
grunt.registerTask("modules", ["clean:modules", "build-modules", "replace:base"]);
Expand Down

0 comments on commit 420c21f

Please sign in to comment.