[747] Prospective UI test stability improvements #748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't quite normalize the entire suite (yet), but it attempts to improve the underpinnings of the
testPagesAdjustToNewPhrases
test, which currently fails intermittently. Any other tests that share those underpinnings have been updated to match.throws
has been introduced into many helper functions. This may not be strictly necessary, but it allows the Swift code to read more clearly, showing how/when a failure might occur. We can dial that back as it makes sense.tap(afterWaitingForExistenceWithTimeout:)
has been replaced withtapWhenExists(timeout: TimeInterval = 0.5)
. This makes the call site more concise and provides a default timeout value.