Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to select cells by blinking #456

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Esquilli
Copy link

#452

Description of Work

Description

  • Added the ability for users to select cells or buttons by blinking.
  • The blink behaves like a normal touch, so cells can be selected repeatedly.
  • Since the blink conforms to UIGestureRecognizer, the user has the ability to start, end, and cancel the gesture.
  • Temporarily, I added a variable inside AppConfig.swift to toggle between hovering and blinking.
  • Provisioning needs to be fixed since I am an external user.

Notes to Test (Optional)

Notes


@SashankPatel
Copy link
Contributor

SashankPatel commented Jun 23, 2022

@Esquilli Do you have bandwidth to take a look at the merge conflicts? We did a couple releases since we had dedicated allocation and specific features to release, looks like that rework caused your fork to be out of date.

Copy link
Contributor

@pg8wood pg8wood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending a couple minor changes.

@jrtb would you be able to add me to the vocable slack channel? I can make these changes in my spare time if the team has decided to accept this work

CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = 753J68XC6W;
DEVELOPMENT_TEAM = L4CX4QKSV5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to undo the provisioning-related changes

@@ -25,6 +30,9 @@ struct AppConfig {
static var isHeadTrackingSupported: Bool {
return ARFaceTrackingConfiguration.isSupported
}

@PublishedDefault(key: "selectionMode", defaultValue: .blink)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want the existing "hover" selection mode to remain the same until we build in a toggle to let users change their preferred selection mode

@pg8wood
Copy link
Contributor

pg8wood commented Nov 4, 2022

@Clstroud I filled out the Join our Slack form, but I haven't received an invitation and it seems my old account was deactivated. Would you be able to ask IT if I can be added as a guest to that external channel? I'm interested in contributing in my spare time 🙏

@SashankPatel
Copy link
Contributor

@Clstroud I filled out the Join our Slack form, but I haven't received an invitation and it seems my old account was deactivated. Would you be able to ask IT if I can be added as a guest to that external channel? I'm interested in contributing in my spare time 🙏

Hey Patrick, trying to get you added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants