Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

380: Decreases individual category padding #529

Merged
merged 1 commit into from
May 24, 2024

Conversation

cinadia
Copy link
Contributor

@cinadia cinadia commented May 14, 2024

Description:
Decrease individual category padding from 10dp to 5dp to prevent cutoff in landscape orientation.

Screenshots:
image

  • Acceptance Criteria satisfied
  • Regression Testing

@cinadia cinadia linked an issue May 14, 2024 that may be closed by this pull request
@cinadia cinadia marked this pull request as ready for review May 14, 2024 18:16
@PaulKlauser
Copy link
Collaborator

Thanks for the contribution @cinadia ! 😁 This looks good to me as far as fixing the original bug, let's merge it in! Before marking the ticket as complete though, can you look into why the rows are being constrained to the smaller height that resulted in clipping the text in the first place? My expectation would be that the original padding value would only cause an issue if the rows themselves were being forced to be smaller than they need to be, and I think the UX would be better if they were allowed to expand a little.

@PaulKlauser PaulKlauser merged commit 492d140 into main May 24, 2024
3 checks passed
@PaulKlauser PaulKlauser deleted the 380-category-names-cut-off-in-landscape branch May 24, 2024 12:42
@cinadia
Copy link
Contributor Author

cinadia commented May 24, 2024

@PaulKlauser I believe it's because the heights of the individual edit category button is set to the same height as the arrow button, which just isn't enough space given the original padding.

In land/category_edit_button.xml:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Category Names Cut Off In Landscape
2 participants