Ignore RequestVote when leader is established. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behavior is described in the original Raft paper and is required to prevent removed nodes from disrupting the cluster. This causes other problems though, as a split node may trigger election which is rejected but leaves it with a future term. The generally accepted solution for this appears to be the use of PreVote RPC to avoid election that can never succeed.
|
Thanks! It's great to get this one covered off |
|
@willemt I think it may be a good idea to leave an open issue to explore the PreVote topic (see above), as this is an immediate but not a complete fix. |
|
ok, it would be a good addition: #78 |
liw
referenced
this pull request
in daos-stack/raft
Feb 9, 2021
This behavior is described in the original Raft paper and is required to prevent removed nodes from disrupting the cluster. This causes other problems though, as a split node may trigger election which is rejected but leaves it with a future term. The generally accepted solution for this appears to be the use of PreVote RPC to avoid election that can never succeed. Signed-off-by: Li Wei <wei.g.li@intel.com>
liw
referenced
this pull request
in daos-stack/raft
Feb 9, 2021
This behavior is described in the original Raft paper and is required to prevent removed nodes from disrupting the cluster. This causes other problems though, as a split node may trigger election which is rejected but leaves it with a future term. The generally accepted solution for this appears to be the use of PreVote RPC to avoid election that can never succeed. Signed-off-by: Li Wei <wei.g.li@intel.com>
liw
referenced
this pull request
in daos-stack/raft
Feb 18, 2021
This behavior is described in the original Raft paper and is required to prevent removed nodes from disrupting the cluster. This causes other problems though, as a split node may trigger election which is rejected but leaves it with a future term. The generally accepted solution for this appears to be the use of PreVote RPC to avoid election that can never succeed. Signed-off-by: Li Wei <wei.g.li@intel.com>
liw
referenced
this pull request
in daos-stack/raft
Feb 18, 2021
This behavior is described in the original Raft paper and is required to prevent removed nodes from disrupting the cluster. This causes other problems though, as a split node may trigger election which is rejected but leaves it with a future term. The generally accepted solution for this appears to be the use of PreVote RPC to avoid election that can never succeed. Signed-off-by: Li Wei <wei.g.li@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior is described in the original Raft paper and is required to
prevent removed nodes from disrupting the cluster.
This causes other problems though, as a split node may trigger election
which is rejected but leaves it with a future term. The generally
accepted solution for this appears to be the use of PreVote RPC to avoid
election that can never succeed.