Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider web banner preferences before displaying campaign modal #4850

Merged
merged 8 commits into from
May 16, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T352306

Notes

This PR fetches the web banner preferences upon login and checks them before displaying campaign modals. If there's any issue and we don't know their preferences, we display the campaign modal by default.

Test Steps

  1. On a device, set Japan as Region and set English as language. Change device date to May 30.
  2. On desktop, log into your account on EN Wiki and uncheck Fundraising in banner preferences.
  3. On device, fresh install on Staging. Background and foreground once on Explore feed, then pull to refresh to trigger campaign fetch.
  4. Visit article on EN Wiki, confirm fundraising modal does NOT show.
  5. Check preference on web.
  6. Repeat steps 3-4 and confirm you do see a modal.

Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Nice to see the new swift concurrency stuff working well with our app!

@mazevedofs mazevedofs merged commit 3b89d03 into main May 16, 2024
4 checks passed
@mazevedofs mazevedofs deleted the T352306 branch May 16, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants