Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use particular campaign ID format for fundraising metrics #4848

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T352717

Notes

This PR modifies the campaign_id format when sending fundraising metrics. Note that we do still need to retain the old format and send to the submitPayment endpoint. I kept that logic as-is (generally called bannerID and is sourced from the config asset's utm_source value), but I updated all the metrics call sites to accept a new metricsID.

Test Steps (Optional)

  1. Change device region to Japan, device date to May 29th. Add card to Apple Wallet.
  2. Fresh install on Staging. Background, foreground, pull to refresh to fetch campaign configs.
  3. Tap to article to trigger campaign modal.
  4. Add breakpoint here, here and here.
  5. Tap Donate button. Confirm first breakpoint is hit and campaign ID follows format enJP_2024_05_iOS.
  6. Tap Apple Pay method. Submit payment. Confirm second breakpoint is hit and campaign ID follows format enJP_2024_05_iOS.
  7. Continue debugging. Confirm third breakpoint is hit and banner ID follows format app_2024_JP_iOS_control. Stop Xcode now to avoid charges.

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team May 7, 2024 16:41
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@mazevedofs mazevedofs merged commit 3154e06 into main May 16, 2024
4 checks passed
@mazevedofs mazevedofs deleted the T352717 branch May 16, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants