Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove emdash workaround #4812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove emdash workaround #4812

wants to merge 1 commit into from

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T361868

Notes

I clearly did this for a reason in the past, but I can no longer reproduce the find and replace bug mentioned in the comment. Removing the workaround.

Test Steps

  1. Open native editor
  2. Long press on hyphen in keyboard - press emdash (longest dash) character.
  3. Confirm character inserts.

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team April 16, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazevedofs mazevedofs Awaiting requested review from mazevedofs mazevedofs was automatically assigned from wikimedia/ios

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@tonisevener