Native Editor - naming cleanup #4751
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonisevener
requested review from
a team and
mazevedofs
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T357073
Notes
This PR contains some class name changes for native editor code. For anything that was reused from our old web editor, I removed the word
Section, since the new editor is capable of editing the full source now. I also decided to renamePageEditorViewController(which was the native-editor app-side container view controller) to justEditorViewController.Pagefelt a bit superfluous at this stage of the feature.Note: The web editor does exist in this branch, so you will see some class names with
Sectionin them. That code will be removed entirely in #4743.Test Steps