Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Java test classes to Kotlin #4665

Merged
merged 9 commits into from
May 16, 2024
Merged

Convert Java test classes to Kotlin #4665

merged 9 commits into from
May 16, 2024

Conversation

cooltey
Copy link
Collaborator

@cooltey cooltey commented May 14, 2024 •
edited

  • Converts test cases in page and dataclient/okhttp packages.
  • Combines two getToken() functions into one with a default null on svc.
  • Removes unused @JvmStatic from functions
  • Removes unnecessary setLocale() from LanguageUtilTest
  • Moves LanguageVariantTest to language package and converts it to Kotlin

@cooltey cooltey added the Minor Minor stuff label May 14, 2024
@cooltey cooltey requested a review from dbrant as a code owner May 14, 2024 23:11
@cooltey cooltey changed the title Convert OfflineCache and AvailableInputStream test classes to Kotlin Convert Java test classes to Kotlin May 15, 2024
@cooltey cooltey removed the Minor Minor stuff label May 15, 2024
@dbrant dbrant merged commit 6d0fe80 into main May 16, 2024
1 check passed
@dbrant dbrant deleted the kotlin-test-cases branch May 16, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@cooltey @dbrant