[Spike] Experiment with Jetpack Compose #4617
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid-wikipedia into compose-experimental
|
The lint error will be fixed after Google releases new version of AGP: https://issuetracker.google.com/issues/330911660 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the migration strategy:
https://developer.android.com/develop/ui/compose/migrate/strategy
Ideally, we should create a new screen without having an XML file, but we do not have a new feature that needs a new screen, so I picked the "Send feedback" button in
AboutActivity, which replaced the<Button>withComposeView.The TODOs will be:
@Composablefunction with our styles definition in thestyles.xml.Findings:
checkstylefailure.@Previewannotation does not work on some UI elements (e.g.AndroidView)Bug: T358019