Hygiene: Remove useless constructor from Page, and improve ns detection. #4605
+6
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrant
added
the
HOLD
dbrant
added
Ready to merge
dbrant
commented
Jun 3, 2024
| val displayTitle = pageProperties.displayTitle | ||
| val isMainPage = pageProperties.isMainPage | ||
| val isArticle = !isMainPage && title.namespace() === Namespace.MAIN | ||
| val isArticle = !isMainPage && pageProperties.namespace.main() |
There was a problem hiding this comment.
The main goal, as with previous similar PRs, is to reduce dependence on the PageTitle.namespace() function, which does not do exactly what we expect, and should eventually be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PageProperties class has a useless constructor, and the Page class performs an incorrect check for
Namespace.MAINthat is better done via PageProperties.