Simplifications

src/liabilities.cpp

@@ -404,13 +404,7 @@ void budget::show_liabilities(budget::writer& w){
 }
 
 bool budget::liability::is_fi() const {
-    for (const auto& [class_id, alloc] : classes) {
-        if (get_asset_class(class_id).fi) {
-            return true;
-        }
-    }
-
-    return false;
+    return std::ranges::any_of(classes, [](auto & c) { return get_asset_class(c.first).fi; });
 }
 
 bool budget::liability_exists(size_t id){

src/money.cpp

@@ -82,8 +82,8 @@ budget::money budget::random_money(long min, long max){
     static std::random_device rd;
     static std::mt19937_64 engine(rd());
 
-    std::uniform_int_distribution<long> dollars_dist(min, max);
-    std::uniform_int_distribution<int> cents_dist(0, 99);
+    std::uniform_int_distribution dollars_dist(min, max);
+    std::uniform_int_distribution cents_dist(0, 99);
 
     return {dollars_dist(engine), cents_dist(engine)};
 }

src/retirement.cpp

@@ -214,7 +214,7 @@ void budget::retirement_status(budget::writer& w) {
     contents.push_back({""s, ""s});
     contents.push_back({"Current Withdrawal Rate"s, to_string(100.0 * (expenses / nw)) + "%"});
     contents.push_back({"Months of FI"s, to_string(nw / (expenses / 12))});
-    contents.push_back({"Years of FI"s, to_string(nw / (expenses))});
+    contents.push_back({"Years of FI"s, to_string(nw / expenses)});
 
     contents.push_back({""s, ""s});
     contents.push_back({"Current Yearly Allowance"s, to_string(nw * (wrate / 100.0))});