Minimizing Browser Window

[soumyashaw]

Issue that this pull request solves

Closes: #295

Proposed changes

Minimizes the Browser window for Terminal Chat mode

Types of changes

Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update (Documentation content changed)
• Other (please describe):

Checklist

Put an x in the boxes that apply

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

Other information

Tested the working on my system (Windows)

[rpotter12]

@soumyashaw minimizing browser window should be in every option. currently by this PR it will minimize the browser in chatting only.

[soumyashaw]

Should I remove the whitespaces?

[rpotter12]

@soumyashaw Remove whitespaces and resolve the conflicts

[soumyashaw]

I don't understand the change needed. Could you give some insight @rpotter12

[rpotter12]

I don't understand the change needed. Could you give some insight @rpotter12

To make code easily readable we follow some basic rules to write a good code like we use PEP8 to do it.

[rpotter12]

@soumyashaw Instead of adding same code in each file, create a function in browser_config.py file and add the code in that function and call that function in each file.

Adding same type of code in each decreases the code quality.

[rpotter12]

Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- wplay/terminal_chat.py  1
         

See the complete overview on Codacy

[soumyashaw]

The changes you suggested are done.

[soumyashaw]

@rpotter12

[rpotter12]

@soumyashaw I need to test it first. :)

[rpotter12]

@soumyashaw win32gui and win32con are only compatible with windows. Try to find the solution which can be executable in all the platforms.

[xandao-dev]

This is not a good approach, in addition to being for windows only adds additional libraries. Pyppeteer has an option to hide the browser, the "headless" parameter must be set in this function below. Changes in the session manager will also be necessary, since it is necessary to show the browser when the user is not logged in.

https://github.com/rpotter12/whatsapp-play/blob/1d3103001b66c77e9aee82a386e224752ada6d05/wplay/utils/browser_config.py#L124

[soumyashaw]

I saw that part in Pyppeteer and that's why didn't use that as it won't serve the purpose.

[rpotter12]

I saw that part in Pyppeteer and that's why didn't use that as it won't serve the purpose.

@soumyashaw Implement that solution which can be run in all platform.