Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node16 update #198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Node16 update #198

wants to merge 2 commits into from

Conversation

oskarbukovsky
Copy link

@oskarbukovsky oskarbukovsky commented Jan 16, 2023

I tried to manual edit node12 to node16 in action.yml and it seems to kinda work.
Only wrong think i see while uploading in log is not correct progress

Upload release.zip -> /test/release.zip: 175672527 Bytes
Uploaded NaN% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Uploaded Infinity% release.zip
Success undefined

@oskarbukovsky oskarbukovsky changed the title Edit Node16 update Jan 16, 2023
@whalemare
Copy link
Owner

Thank you for PR!
Can you please fix this Uploaded Infinity% release.zip too?

@oskarbukovsky
Copy link
Author

oskarbukovsky commented Jan 21, 2023

I quickly looked at code and found
this.logger?.info(`Uploaded ${(uploaded / total) * 100}% ${file}`)
,maybe division with zero?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants