Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a custom gid. #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rjkroege
Copy link

Permit the package author to specify a custom gid by providing a
io.whalebrew.config.customgid label.

@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #64 into master will increase coverage by 0.14%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   47.72%   47.86%   +0.14%     
==========================================
  Files          15       15              
  Lines         792      798       +6     
==========================================
+ Hits          378      382       +4     
- Misses        385      386       +1     
- Partials       29       30       +1
Impacted Files Coverage Δ
run/docker.go 85.18% <100%> (+0.87%) ⬆️
packages/package.go 61.29% <33.33%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c8d32...c5ee57e. Read the comment docs.

@rjkroege
Copy link
Author

Ping: I updated this. WDYT?

@tjamet
Copy link
Contributor

tjamet commented Dec 11, 2019

I was thinking about it, thought I posted the question earlier.
We already have a "keep container user" flag.
I see a single case where this could be used which is to use the current user id on the host, but keep the group id in the container, do you foresee use cases of this?

@rjkroege
Copy link
Author

Yes. I had to add this to make a working whalebrew wrapper on MacOS for the Docker functionality of Google's gcloud tool where the gcloud in the container uses the host's Docker daemon.

Permit the package author to specify a custom gid by providing a
io.whalebrew.config.customgid label.
@rjkroege
Copy link
Author

Rebased.

@tjamet
Copy link
Contributor

tjamet commented Dec 13, 2019

Are you using docker for Mac?
Docker for Mac has some kind of user remapping, as mounting the files in a VM, which makes that when creating and accessing files in the container, the user and group ID of the container user is used, while on the local filesystem, it is seen as the current user

image

Since there is now a label to keep the user ID and group an image defines LABEL io.whalebrew.config.keep_container_user 'true', I am trying to understand how specifying the group only is a distinct use case.

Can you share the package (yaml) that is not working together with the required snippets to reproduce?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants