Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GoLang to 1.20 & dependency updates #229

Closed

Conversation

jamesalfei
Copy link

A number of changes have been made as part of this PR which I will summarise below:

  • GoLang version has been updated to 1.20 (latest)
  • GitHub actions have all been updated to use the latest major versions of all action steps
  • Deprecated function usage has been replaced with the corresponding current implementation equivalent
  • Various go fmt issues fixed in addition to IntelliJ automated analysis findings

If you would prefer this PR to be broken up and raised as separate requests, please let me know and I'd be more than happy to fulfil that request :)

@tjamet
Copy link
Contributor

tjamet commented Sep 20, 2023

Hi!
Thanks for your contribution, those are a lot of changes at once.
Would you mind splitting it into smaller PRs?

Probably:
1 PR for golang update
1 PR for go nodules update
1 PR for actions update
1 PR for cosmetic changes

Thank you

@tjamet
Copy link
Contributor

tjamet commented Sep 20, 2023

actually, as part of investigating #200 I envision applying the version updates independently.
I would though encourage you to submit an updated PR with the rest of the changes.

@jamesalfei jamesalfei closed this May 20, 2024
@jamesalfei jamesalfei deleted the update-golang-resolve-issues branch May 20, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants