Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data-ajax - Fix ajax filter option to consider spaces in the CSS selector #9758

Merged
merged 1 commit into from
May 15, 2024

Conversation

duboisp
Copy link
Member

@duboisp duboisp commented Apr 30, 2024

Feature addition to filter out content via data-ajax which is provided by the ajax-fetch plugin.

@duboisp duboisp requested a review from Garneauma April 30, 2024 02:30
src/plugins/ajax-fetch/ajax-fetch.js Outdated Show resolved Hide resolved
src/plugins/ajax-fetch/ajax-fetch.js Outdated Show resolved Hide resolved
src/plugins/ajax-fetch/ajax-fetch.js Outdated Show resolved Hide resolved
src/plugins/data-ajax/data-ajax-en.hbs Outdated Show resolved Hide resolved
src/plugins/data-ajax/data-ajax-en.hbs Outdated Show resolved Hide resolved
src/plugins/data-ajax/data-ajax-en.hbs Outdated Show resolved Hide resolved
src/plugins/data-ajax/data-ajax-fr.hbs Outdated Show resolved Hide resolved
src/plugins/data-ajax/data-ajax-fr.hbs Outdated Show resolved Hide resolved
src/plugins/data-ajax/data-ajax-fr.hbs Outdated Show resolved Hide resolved
@Garneauma
Copy link
Contributor

Pre-approved upon successful review and requested changes being done.

@Garneauma Garneauma added this to the v4.0.80 milestone May 6, 2024
@duboisp duboisp changed the title Data-ajax - Add option to filter out content via a selector Data-ajax - Fix ajax filter option to consider spaces in the CSS selector May 14, 2024
Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary sentence. Other than that, everything works as expected and other ajax elements are not affected.

src/plugins/data-ajax/data-ajax-en.hbs Outdated Show resolved Hide resolved
src/plugins/data-ajax/data-ajax-fr.hbs Outdated Show resolved Hide resolved
@Garneauma Garneauma merged commit 1d4559c into wet-boew:master May 15, 2024
2 checks passed
duboisp pushed a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants