Core: edit DOMPurify sanitization to allow external links #9757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pre-approved upon successful review. |
duboisp
requested changes
May 14, 2024
duboisp
approved these changes
May 15, 2024
There was a problem hiding this comment.
Reviewed and tested locally. Everything look fine.
Also, I noticed a little performance improvement of the data-ajax working example page compared to my yesterday test. I don't know if that is caused by your latest update or if that is caused by something else running on my test computer.
|
Note: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External links are safe to include in web pages given that they also have a
relattribute containing the value"noreferrer". See the following link for a more detailed explanation: https://owasp.org/www-community/attacks/Reverse_Tabnabbing