Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geomap: adding option to merge legend label and symbol #9752

Merged
merged 1 commit into from Apr 30, 2024

Conversation

Garneauma
Copy link
Contributor

Geomap: Adding the option to hide the symbol's description when there is only one item in the legend layer as the description is most likely the same as the label.

Changes related to WET-450

@Garneauma Garneauma requested a review from duboisp April 29, 2024 14:04
@Garneauma
Copy link
Contributor Author

Pre-approved upon successful review.

@Garneauma Garneauma added this to the v4.0.79 milestone Apr 29, 2024
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little change to add a comment for some clarity in the code.

I reviewed all the code/example and tested locally, everything do work as expected and nothing to report.

Once the little comment is added, it will be good to merge.

src/plugins/deps/geomap-lib.js Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and all good.

This is a minor change.

@Garneauma Garneauma merged commit 4fc7561 into wet-boew:master Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants