Add to calendar: Stabilization #9533
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garneauma
force-pushed
the
WET-274
branch
2 times, most recently
from
c57aaaf
to
c86b548
Compare
polmih
requested changes
Feb 28, 2023
|
I didn't review the files concerning dropdown plugin since the review was done in its own PR (confirmed with Marc-Andre that the changes are identical) |
|
Thank you for the review @polmih ! |
polmih
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stabilizing Add to calendar plugin leveraging new dropdown plugin and Bootstrap's dropdown styling.
Dependent on:
PR Build: Bump grunt-contrib-uglify to 5.2.1 to support new JS features #9531
PR Dropdown: implementing dropdown plugin #9532
Remove files related to above PR's when they are merged.
Changes related to WET-274.