Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multimedia Player - YouTube: WGAG 2.1 & 2.2 AA Assessment #9520

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

BrahimMahadi
Copy link
Contributor

This pull request includes the WCAG 2.1 & 2.2 Accessibility assessment done for the YouTube version of the multimedia plugin

General checklist

  • Updated multimedia documentation to include the accessibility assessment reports
  • Plugin was tested against WCAG for accessibility
  • Documentation is bilingual

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrahimMahadi please update your assessment according to the new methodologies and the revised vocabulary terms

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to add link to this new report from the multimedia documentation in a new section named "Reports" after the example here: https://github.com/wet-boew/wet-boew/blob/master/site/pages/docs/ref/multimedia/multimedia-en.hbs#L30

Considering the automated tool has reported some faillure, I assume that you revalidated those Success Criteria to ensure they are passing. If so, I suggest to add a little comment in that matter via the "dct:description" field of your semi-automated SC assessment item. Like at line 1471 of the JSON-LD report for the keyboard navigation.

Nice work with the report conversion, it works as expected.

Thanks

src/plugins/multimedia/reports/a11y-1-youtube.json Outdated Show resolved Hide resolved
src/plugins/multimedia/reports/a11y-1-youtube-en.hbs Outdated Show resolved Hide resolved
@duboisp
Copy link
Member

duboisp commented Aug 22, 2023

Il va falloir enlever les merges commits.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline comments,

Please remove the merge commit. For that you can reset hard to the upstream/master and then use "git cherry-pick " to insert your changes where "" is replaced by your commit ID related to this PR.

As example, to test your PR I did manually cherry picked the following commit ID

src/plugins/multimedia/reports/a11y-1-youtube.json Outdated Show resolved Hide resolved
src/plugins/multimedia/reports/a11y-1-youtube.json Outdated Show resolved Hide resolved
@duboisp
Copy link
Member

duboisp commented Sep 6, 2023

@BrahimMahadi there is too much/duplicate commit in this PR. You can probably restart fresh and then cherry-pick the applicable commit for this PR.
git cherry-pick commitID where "commitID" is the SHA hash

@duboisp duboisp added the Query: Project item Support a github project label Sep 21, 2023
@BrahimMahadi
Copy link
Contributor Author

@duboisp The merge commit has been removed

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 little change

src/plugins/multimedia/reports/a11y-1-youtube.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query: Project item Support a github project
Projects
Status: For Review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants