New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multimedia Player - YouTube: WGAG 2.1 & 2.2 AA Assessment #9520
base: master
Are you sure you want to change the base?
Conversation
0524245
to
ca6731e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BrahimMahadi please update your assessment according to the new methodologies and the revised vocabulary terms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to add link to this new report from the multimedia documentation in a new section named "Reports" after the example here: https://github.com/wet-boew/wet-boew/blob/master/site/pages/docs/ref/multimedia/multimedia-en.hbs#L30
Considering the automated tool has reported some faillure, I assume that you revalidated those Success Criteria to ensure they are passing. If so, I suggest to add a little comment in that matter via the "dct:description" field of your semi-automated SC assessment item. Like at line 1471 of the JSON-LD report for the keyboard navigation.
Nice work with the report conversion, it works as expected.
Thanks
Il va falloir enlever les merges commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the inline comments,
Please remove the merge commit. For that you can reset hard to the upstream/master and then use "git cherry-pick " to insert your changes where "" is replaced by your commit ID related to this PR.
As example, to test your PR I did manually cherry picked the following commit ID
@BrahimMahadi there is too much/duplicate commit in this PR. You can probably restart fresh and then cherry-pick the applicable commit for this PR. |
@duboisp The merge commit has been removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 little change
- Fix the CSS selector of the tested subject in the report. I think that you might only need to remove the spaces.
- Add a link (EN and FR) to this report in the multimedia documentation under the heading: "Evaluation and report" - https://github.com/wet-boew/wet-boew/blob/master/site/pages/docs/ref/multimedia/multimedia-en.hbs#L33-L38
This pull request includes the WCAG 2.1 & 2.2 Accessibility assessment done for the YouTube version of the multimedia plugin
General checklist