Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay - Prevent background content to scroll #9334

Merged
merged 2 commits into from
May 11, 2022

Conversation

Christopher-O
Copy link
Contributor

@Christopher-O Christopher-O commented May 10, 2022

(Pick the language of your choice to fill out the following information. / Choisissez la langue de votre choix pour remplir l'information ci-dessous.)

What does this pull request (PR) do? / Que fait cette demande « pull » (PR)?

Adds style to body for overlay [mid-screen, full-screen, full-screen hidden-header, mid-screen with background] in order to remove scrollbar of content behind the overlay when active. This will avoid the user from scrolling the background content while navigating the overlay content.

Added style to body for overlay [mid-screen, full-screen, full-screen hidden-header, mid-screen with background] in order to avoid to allow scroll of content behind overlay when active.
removed whitespace trail
@duboisp duboisp changed the title Update _base.scss Overlay - Prevent background content to scroll May 11, 2022
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved upon successful testing

Copy link
Contributor

@Ricokola Ricokola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Middle Screen Overly locally and noticed that the background still scroll when the overlay is active so this functionality failed.

Only have one scrolling bar when reducing my viewport so this functionality pass.

Copy link
Contributor

@Ricokola Ricokola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested the changes locally and work as expected so good to merged.

@duboisp duboisp merged commit b762a5a into wet-boew:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants