When adding custom close button. Default one stay usable

[crochefort]

When we add a custom close button, it show 2 close buttons

What does this pull request (PR) do? / Que fait cette demande « pull » (PR)?

Fix only class overlay-close is needed for overlay not lightbox

• [x ] Create/update documentation /// Créer/mettre à jour la documentation
• [x ] Build and test PR's code /// Rouler le script de compilation et tester le code de la PR
• Validate changes against WCAG for accessibility /// Valider les changements avec WCAG pour l'accessibilité
• Ensure documentation is bilingual /// S'assurer que la documentation soit bilingue

Screenshots / Captures d'écrans

@duboisp

[duboisp]

@crochefort can you also make the adjustment in the instruction on how to add the close button here:

• https://github.com/wet-boew/wet-boew/blob/master/src/plugins/overlay/overlay-en.hbs#L226
• https://github.com/wet-boew/wet-boew/blob/master/src/plugins/overlay/overlay-fr.hbs#L228

Thank you

[crochefort]

@duboisp No need to edit the documentation since it was OK in the doc.

[duboisp]

@crochefort Can you update the following line in the working example page:
For: https://github.com/wet-boew/wet-boew/blob/master/src/plugins/overlay/overlay-en.hbs#L230
Currently

<button class="btn btn-primary popup-modal-dismiss" type="button">Close overlay/modal</button>

Need to be updated like:

<button class="btn btn-primary overlay-close" type="button">Close overlay/modal</button>

Change is to replace "popup-modal-dismiss" with "overlay-close".
Similar change is also required for the French working example

[crochefort]

@duboisp Should be ok I think!