Disable event: Fix ampersand in basic HTML mode's activation link #9144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricDunsworth
force-pushed
the
v4.0-disable-ampersand
branch
2 times, most recently
from
126dee6
to
4d7dbb9
Compare
This plugin adds an ampersand before wbdisable=true if the current page's URL contains parameters. The plugin used to build basic HTML mode's activation link using innerHTML. Later on, wet-boew#9036 changed it to use the addSkipLink helper method. However, that changed how the ampersand got interpreted. It started getting double-escaped (&&wet-boew#38;). This resolves it by changing the ampersand from a numeric entity into a normal ampersand character. It'll get transformed into & upon being inserted into the page by addSkipLink. The addSkipLink method uses setAttribute (which expects plain-text values) to set the activation link's destination. Afterwards, appendChild subsequently changes the ampersand into a named entity. Fixes wet-boew#9139.
EricDunsworth
force-pushed
the
v4.0-disable-ampersand
branch
from
4d7dbb9
to
1dda10d
Compare
GormFrank
approved these changes
Aug 11, 2021
EricDunsworth
added a commit
to EricDunsworth/wet-boew
that referenced
this pull request
Aug 11, 2021
Activating the "switch to standard version" link while in basic HTML mode previously caused a trailing ampersand to appear in the URL if the page contained multiple URL parameters. This removes it by using a case-insensitive regex to check for an optional ampersand before "wbdisable=false". Complements wet-boew#9144.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin adds an ampersand before
wbdisable=trueif the current page's URL contains parameters.The plugin used to build basic HTML mode's activation link using
innerHTML. Later on, #9036 changed it to use theaddSkipLinkhelper method.However, that changed how the ampersand got interpreted. It started getting double-escaped (
&&).This resolves it by changing the ampersand from a numeric entity into a normal ampersand character. It'll get transformed into
&upon being inserted into the page byaddSkipLink.The
addSkipLinkmethod usessetAttribute(which expects plain-text values) to set the activation link's destination. Afterwards,appendChildsubsequently changes the ampersand into a named entity.Fixes #9139.
Related reading: